logging: include spdlog log_msg in log to SinkDelegate#18854
Merged
snowp merged 1 commit intoenvoyproxy:mainfrom Nov 4, 2021
Merged
logging: include spdlog log_msg in log to SinkDelegate#18854snowp merged 1 commit intoenvoyproxy:mainfrom
snowp merged 1 commit intoenvoyproxy:mainfrom
Conversation
This allows sinks to inspect the log line details without parsing the formatted message. Signed-off-by: Snow Pettersen <snowp@lyft.com>
jmarantz
approved these changes
Nov 4, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Snow Pettersen snowp@lyft.com
Commit Message: This allows sinks to inspect the log line details without parsing the formatted message.
Additional Description: n/a
Risk Level: Medium
Testing: New UTs
Docs Changes: n/a
Release Notes: n/a
Platform Specific Features: n/a