Skip to content

[rbac]: Fix extension name. #18848

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ggreenway merged 1 commit into from
Nov 2, 2021
Merged

[rbac]: Fix extension name. #18848

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion source/extensions/filters/common/rbac/matchers/upstream_ip_port.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ class UpstreamIpPortMatcherFactory
UpstreamIpPortMatcher,
envoy::extensions::rbac::matchers::upstream_ip_port::v3::UpstreamIpPortMatcher> {
public:
std::string name() const override { return "envoy.rbac.matchers.upstream.upstream_ip_port"; }
std::string name() const override { return "envoy.rbac.matchers.upstream_ip_port"; }
};

} // namespace Matchers
Expand Down
8 changes: 4 additions & 4 deletions test/extensions/filters/http/rbac/rbac_filter_integration_test.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -636,7 +636,7 @@ name: rbac
- or_rules:
rules:
- matcher:
name: envoy.filters.http.rbac.matchers.upstream_ip_port
name: envoy.rbac.matchers.upstream_ip_port
typed_config:
"@type": type.googleapis.com/envoy.extensions.rbac.matchers.upstream_ip_port.v3.UpstreamIpPortMatcher
upstream_ip:
Expand Down Expand Up @@ -679,21 +679,21 @@ name: rbac
- or_rules:
rules:
- matcher:
name: envoy.filters.http.rbac.matchers.upstream_ip_port
name: envoy.rbac.matchers.upstream_ip_port
typed_config:
"@type": type.googleapis.com/envoy.extensions.rbac.matchers.upstream_ip_port.v3.UpstreamIpPortMatcher
upstream_ip:
address_prefix: 127.2.1.1
prefix_len: 24
- matcher:
name: envoy.filters.http.rbac.matchers.upstream_ip_port
name: envoy.rbac.matchers.upstream_ip_port
typed_config:
"@type": type.googleapis.com/envoy.extensions.rbac.matchers.upstream_ip_port.v3.UpstreamIpPortMatcher
upstream_ip:
address_prefix: 127.0.0.1
prefix_len: 24
- matcher:
name: envoy.filters.http.rbac.matchers.upstream_ip_port
name: envoy.rbac.matchers.upstream_ip_port
typed_config:
"@type": type.googleapis.com/envoy.extensions.rbac.matchers.upstream_ip_port.v3.UpstreamIpPortMatcher
upstream_ip:
Expand Down