ecds: templatize FilterConfigProviderManagerImpl#18832
Merged
lizan merged 2 commits intoenvoyproxy:mainfrom Nov 5, 2021
Merged
ecds: templatize FilterConfigProviderManagerImpl#18832lizan merged 2 commits intoenvoyproxy:mainfrom
lizan merged 2 commits intoenvoyproxy:mainfrom
Conversation
Signed-off-by: Taylor Barrella <tabarr@google.com>
Signed-off-by: Taylor Barrella <tabarr@google.com>
Contributor
|
/assign-from @envoyproxy/first-pass-reviewers |
|
@envoyproxy/first-pass-reviewers assignee is @KBaichoo |
KBaichoo
approved these changes
Nov 2, 2021
Contributor
KBaichoo
left a comment
KBaichoo
left a comment
There was a problem hiding this comment.
lgtm, thanks for the refactor.
Contributor
|
@asraa PTAL |
asraa
approved these changes
Nov 5, 2021
Contributor
asraa
left a comment
asraa
left a comment
There was a problem hiding this comment.
Change looks good to me. @envoyproxy/envoy-maintainers can we have non-google review please?
lizan
approved these changes
Nov 5, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cc @kyessenov @lambdai
Commit Message:
ecds: templatize FilterConfigProviderManagerImpl
Signed-off-by: Taylor Barrella tabarr@google.com
Additional Description: Part of #14696 (comment). The refactoring that enables this is mainly within
FilterConfigSubscription::onConfigUpdate. The rest is adding and removing template parameters.Risk Level: Low
Testing: Existing (refactoring)
Docs Changes: N/A
Release Notes: N/A
Platform Specific Features: N/A
#14696