Simlify convertion from absl string_view#18811
Conversation
|
Hi @theidexisted, welcome and thank you for your contribution. We will try to review your Pull Request as quickly as possible. In the meantime, please take a look at the contribution guidelines if you have not done so already. |
|
Seems fine, can you check CI? |
|
envoy-presubmit (check linux_x64 clang_tidy) |
|
Could you please fix the DCO check? See here: https://github.com/envoyproxy/envoy/blob/ad63b1c385fe95ddd6d547a43583904c1f459abe/CONTRIBUTING.md#fixing-dco |
Thank you for the guide, I will follow it. But for the clang-tidy check fails, the log doesn't tell the reason, could you please help me find the reason? |
Signed-off-by: theidexisted <invalid_ms_user@live.com>
|
I think it was fine! |
Commit Message: rocketmq_proxy: Simplify the conversion for absl::string_view
Additional Description: N/A
Risk Level: Low
Testing: N/A
Docs Changes: N/A
Release Notes: N/A
Platform Specific Features: N/A
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]