Skip to content

Simlify convertion from absl string_view#18811

Merged
asraa merged 1 commit intoenvoyproxy:mainfrom
theidexisted:patch-1
Nov 4, 2021
Merged

Simlify convertion from absl string_view#18811
asraa merged 1 commit intoenvoyproxy:mainfrom
theidexisted:patch-1

Conversation

@theidexisted
Copy link
Copy Markdown
Contributor

@theidexisted theidexisted commented Oct 28, 2021

Commit Message: rocketmq_proxy: Simplify the conversion for absl::string_view
Additional Description: N/A
Risk Level: Low
Testing: N/A
Docs Changes: N/A
Release Notes: N/A
Platform Specific Features: N/A
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]

@theidexisted theidexisted requested a review from lizan as a code owner October 28, 2021 09:50
@repokitteh-read-only
Copy link
Copy Markdown

Hi @theidexisted, welcome and thank you for your contribution.

We will try to review your Pull Request as quickly as possible.

In the meantime, please take a look at the contribution guidelines if you have not done so already.

🐱

Caused by: #18811 was opened by theidexisted.

see: more, trace.

@snowp
Copy link
Copy Markdown
Contributor

snowp commented Oct 29, 2021

Seems fine, can you check CI?

@theidexisted
Copy link
Copy Markdown
Contributor Author

envoy-presubmit (check linux_x64 clang_tidy)

@asraa
Copy link
Copy Markdown
Contributor

asraa commented Nov 2, 2021

@asraa asraa self-assigned this Nov 2, 2021
@theidexisted
Copy link
Copy Markdown
Contributor Author

Could you please fix the DCO check? See here: https://github.com/envoyproxy/envoy/blob/ad63b1c385fe95ddd6d547a43583904c1f459abe/CONTRIBUTING.md#fixing-dco

Thank you for the guide, I will follow it. But for the clang-tidy check fails, the log doesn't tell the reason, could you please help me find the reason?

Signed-off-by: theidexisted <invalid_ms_user@live.com>
@asraa
Copy link
Copy Markdown
Contributor

asraa commented Nov 4, 2021

I think it was fine!

@asraa asraa merged commit 5317f7c into envoyproxy:main Nov 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants