thrift_proxy: support header flags#18806
Merged
zuercher merged 5 commits intoenvoyproxy:mainfrom Nov 3, 2021
Merged
Conversation
Signed-off-by: Zhangdong Ma <zhdma_xd@163.com>
Contributor
Author
wbpcode
reviewed
Oct 29, 2021
Member
wbpcode
left a comment
There was a problem hiding this comment.
Thanks 🌷 , looks great. One simple comment to start further review.
Member
|
MessageMetadata::clone() should handle header flags as well I think (used
when mirroring requests).
…On Fri, Oct 29, 2021, 4:46 AM code ***@***.***> wrote:
***@***.**** commented on this pull request.
Thanks 🌷 , looks great. One simple comment to start further review.
------------------------------
In .bazelrc
<#18806 (comment)>:
> @@ -38,6 +38,7 @@ build --action_env=CC
build --action_env=CXX
build --action_env=LLVM_CONFIG
build --action_env=PATH
+build --action_env=GOPROXY=https://goproxy.cn
May be this is unnecessary for the community?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#18806 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAKJSA6E2AU5R5S7QDEPPF3UJJNOVANCNFSM5G3YAGKA>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
|
rgs1
suggested changes
Oct 29, 2021
Member
rgs1
left a comment
There was a problem hiding this comment.
Thanks! Please see my prev comment on MessageMetadata::clone().
Signed-off-by: Zhangdong Ma <zhdma_xd@163.com>
…_flags Signed-off-by: Zhangdong Ma <zhdma_xd@163.com>
Signed-off-by: Zhangdong Ma <zhdma_xd@163.com>
Signed-off-by: Zhangdong Ma <zhdma_xd@163.com>
wbpcode
approved these changes
Nov 2, 2021
Member
wbpcode
left a comment
There was a problem hiding this comment.
Thanks. It looks good to me. 😃
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Zhangdong Ma zhdma_xd@163.com
Commit Message: transfer header flags to thrift upstream
Additional Description:
Risk Level: Low
Testing: unit test
Docs Changes: N/A
Release Notes: N/A
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]