Skip to content

thrift_proxy: support header flags#18806

Merged
zuercher merged 5 commits intoenvoyproxy:mainfrom
xiaoma2015:thrift_header_flags
Nov 3, 2021
Merged

thrift_proxy: support header flags#18806
zuercher merged 5 commits intoenvoyproxy:mainfrom
xiaoma2015:thrift_header_flags

Conversation

@xiaoma2015
Copy link
Copy Markdown
Contributor

Signed-off-by: Zhangdong Ma zhdma_xd@163.com

Commit Message: transfer header flags to thrift upstream
Additional Description:
Risk Level: Low
Testing: unit test
Docs Changes: N/A
Release Notes: N/A
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]

Signed-off-by: Zhangdong Ma <zhdma_xd@163.com>
@xiaoma2015 xiaoma2015 requested a review from zuercher as a code owner October 28, 2021 02:32
@xiaoma2015
Copy link
Copy Markdown
Contributor Author

@wbpcode @rgs1

Copy link
Copy Markdown
Member

@wbpcode wbpcode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🌷 , looks great. One simple comment to start further review.

@rgs1
Copy link
Copy Markdown
Member

rgs1 commented Oct 29, 2021 via email

Copy link
Copy Markdown
Member

@rgs1 rgs1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Please see my prev comment on MessageMetadata::clone().

Signed-off-by: Zhangdong Ma <zhdma_xd@163.com>
Signed-off-by: Zhangdong Ma <zhdma_xd@163.com>
Signed-off-by: Zhangdong Ma <zhdma_xd@163.com>
Copy link
Copy Markdown
Member

@wbpcode wbpcode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. It looks good to me. 😃

Copy link
Copy Markdown
Member

@zuercher zuercher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@zuercher zuercher merged commit c418082 into envoyproxy:main Nov 3, 2021
@xiaoma2015 xiaoma2015 deleted the thrift_header_flags branch November 4, 2021 02:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants