Skip to content

bazel: update CMake instructions in EXTERNAL_DEPS.md #18799

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
snowp merged 1 commit into from
Oct 28, 2021
Merged

bazel: update CMake instructions in EXTERNAL_DEPS.md #18799

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion bazel/EXTERNAL_DEPS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ This is the preferred style of adding dependencies that use CMake for their buil

1. Define a the source Bazel repository in [`bazel/repositories.bzl`](repositories.bzl), in the
`envoy_dependencies()` function.
2. Add a `cmake_external` rule to [`bazel/foreign_cc/BUILD`](foreign_cc/BUILD). This will reference
2. Add an `envoy_cmake` rule to [`bazel/foreign_cc/BUILD`](foreign_cc/BUILD). This will reference
the source repository in step 1.
3. Reference your new external dependency in some `envoy_cc_library` via the name bound in step 1
`external_deps` attribute.
Expand Down