[Backport 1.20]:listen socket factory can be cloned from listener draining …#18782
Merged
mathetake merged 3 commits intoenvoyproxy:release/v1.20from Oct 27, 2021
Merged
Conversation
envoyproxy#18686) Signed-off-by: Yuchen Dai <silentdai@gmail.com>
Contributor
Author
|
The |
Contributor
Author
|
/assign @mathetake |
Contributor
Author
|
/retest |
|
Retrying Azure Pipelines: |
Member
…ket_track Signed-off-by: Yuchen Dai <silentdai@gmail.com>
Signed-off-by: Yuchen Dai <silentdai@gmail.com>
Contributor
Author
|
@mathetake Thanks! Added one |
mathetake
approved these changes
Oct 27, 2021
Member
|
Will merge when CI becomes happy |
Member
Contributor
Author
|
@mathetake Thanks! That's a release blocker for sure. Fortunately it's not a test blocker |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…… (#18686)
Commit Message:
Backport 6f0ecc5 to 1.2-
Signed-off-by: Yuchen Dai silentdai@gmail.com
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]