Skip to content

build: fixing merge conflict#18708

Merged
alyssawilk merged 1 commit intoenvoyproxy:mainfrom
alyssawilk:build
Oct 21, 2021
Merged

build: fixing merge conflict#18708
alyssawilk merged 1 commit intoenvoyproxy:mainfrom
alyssawilk:build

Conversation

@alyssawilk
Copy link
Copy Markdown
Contributor

@alyssawilk alyssawilk commented Oct 21, 2021

Risk Level: n/a
Testing: n/a
Docs Changes: n/a
Release Notes: n/a
Fixes #18707

Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
@alyssawilk
Copy link
Copy Markdown
Contributor Author

(haven't done a full build locally yet but this at least lets //test/extensions/clusters/dynamic_forward_proxy:cluster_test build)

@alyssawilk
Copy link
Copy Markdown
Contributor Author

ok,build and test green locally. I'll force merge once I have approval from @envoyproxy/envoy-maintainers

Copy link
Copy Markdown
Member

@phlax phlax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks @alyssawilk

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

build: failed to build Envoy after recent commit

2 participants