Skip to content

Remove redundant Warn log in HTTP codec. (#18699) #18702

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
htuch merged 4 commits into from
Oct 29, 2021
Merged

Remove redundant Warn log in HTTP codec. (#18699) #18702

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
2b150d8
Remove redundant Warn log in HTTP codec. (#18699)
mathetake Oct 21, 2021
b736090
Adding release note for PR #18702
ankatare Oct 27, 2021
ff41917
fix build issues
ankatare Oct 27, 2021
a91af21
ïncorporating review comments by htuch on doc
ankatare Oct 29, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions docs/root/version_history/current.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@ Bug Fixes
---------
*Changes expected to improve the state of the world and are unlikely to have negative effects*

* http codec: remove redundant Warn log in HTTP codec.
Comment thread
ankatare marked this conversation as resolved.
Outdated
* listener: fix a crash when updating any listener that does not bind to port.

Removed Config or Runtime
Expand Down
3 changes: 0 additions & 3 deletions source/common/http/codec_client.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -117,9 +117,6 @@ void CodecClient::onEvent(Network::ConnectionEvent event) {
StreamInfo::ResponseFlag::UpstreamProtocolError);
}
}
} else {
ENVOY_CONN_LOG(warn, "Connection is closed by {} during connecting.", *connection_,
(event == Network::ConnectionEvent::RemoteClose ? "peer" : "self"));
}
while (!active_requests_.empty()) {
// Fake resetting all active streams so that reset() callbacks get invoked.
Expand Down