Skip to content

Remove redundant Warn log in HTTP codec.#18699

Merged
htuch merged 1 commit intomainfrom
remove-unnecessary-log
Oct 21, 2021
Merged

Remove redundant Warn log in HTTP codec.#18699
htuch merged 1 commit intomainfrom
remove-unnecessary-log

Conversation

@mathetake
Copy link
Copy Markdown
Member

Signed-off-by: Takeshi Yoneda takeshi@tetrate.io

This line was introduced in efcf2e5, but it is flooding the log outputs of Envoy users, so this PR just deletes the line. For detail, please refer to #18643.

Signed-off-by: Takeshi Yoneda <takeshi@tetrate.io>
Copy link
Copy Markdown
Member

@htuch htuch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@htuch htuch merged commit 04ad439 into main Oct 21, 2021
@htuch htuch deleted the remove-unnecessary-log branch October 21, 2021 04:28
ankatare pushed a commit to ankatare/envoy that referenced this pull request Oct 27, 2021
This line was introduced in efcf2e5, but it is flooding the log outputs of Envoy users, so this PR just deletes the line. For detail, please refer to envoyproxy#18643.

Signed-off-by: Takeshi Yoneda <takeshi@tetrate.io>
Signed-off-by: Abhay Narayan Katare <abhay.katare@india.nec.com>
htuch pushed a commit that referenced this pull request Oct 29, 2021
This line was introduced in efcf2e5, but it is flooding the log outputs of Envoy users, so this PR just deletes the line. For detail, please refer to #18643.

Fixes #18643

Signed-off-by: Abhay Narayan Katare <abhay.katare@india.nec.com>
Co-authored-by: Takeshi Yoneda <takeshi@tetrate.io>
aidanhahn pushed a commit to gravitee-io/envoy that referenced this pull request Jan 13, 2022
…xy#18702)

This line was introduced in efcf2e5, but it is flooding the log outputs of Envoy users, so this PR just deletes the line. For detail, please refer to envoyproxy#18643.

Fixes envoyproxy#18643

Signed-off-by: Abhay Narayan Katare <abhay.katare@india.nec.com>
Co-authored-by: Takeshi Yoneda <takeshi@tetrate.io>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants