Skip to content

fix some comment error of io_handle.h #18598

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
davinci26 merged 1 commit into from
Oct 13, 2021
Merged

fix some comment error of io_handle.h #18598

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions envoy/network/io_handle.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,6 +108,7 @@ class IoHandle {
* Send a message to the address.
* @param slices points to the location of data to be sent.
* @param num_slice indicates number of slices |slices| contains.
* @param flags flags to pass to the underlying sendmsg function (see man 2 sendmsg).
* @param self_ip is the source address whose port should be ignored. Nullptr
* if caller wants kernel to select source address.
* @param peer_address is the destination address.
Expand Down Expand Up @@ -202,7 +203,6 @@ class IoHandle {
/**
* Bind to address. The handle should have been created with a call to socket()
* @param address address to bind to.
* @param addrlen address length
* @return a Api::SysCallIntResult with rc_ = 0 for success and rc_ = -1 for failure. If the call
* is successful, errno_ shouldn't be used.
*/
Expand All @@ -220,7 +220,6 @@ class IoHandle {
* Accept on listening handle
* @param addr remote address to be returned
* @param addrlen remote address length
* @param flags flags to be applied to accepted session
* @return accepted IoHandlePtr
*/
virtual std::unique_ptr<IoHandle> accept(struct sockaddr* addr, socklen_t* addrlen) PURE;
Expand All @@ -229,7 +228,6 @@ class IoHandle {
* Connect to address. The handle should have been created with a call to socket()
* on this object.
* @param address remote address to connect to.
* @param addrlen remote address length
* @return a Api::SysCallIntResult with rc_ = 0 for success and rc_ = -1 for failure. If the call
* is successful, errno_ shouldn't be used.
*/
Expand Down