Skip to content

[config_validation]: fixing crash in grpc client during shutdown #18532

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
tehnerd wants to merge 3 commits into from
Closed

[config_validation]: fixing crash in grpc client during shutdown #18532

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c77cf24
[config_validation]: fixing crash in grpc client during shutdown
tehnerd Oct 8, 2021
b4bb387
Merge remote-tracking branch 'upstream/main' into fix_shutdown_in_val…
tehnerd Oct 12, 2021
1e633dd
adding description into current.rst
tehnerd Oct 12, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions docs/root/version_history/current.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,7 @@ Bug Fixes
---------
*Changes expected to improve the state of the world and are unlikely to have negative effects*

* config_validation: fix server crash during shutdown when grpc requests to xDS are still in flight.
* listener: fixed the crash when updating listeners that do not bind to port.
* thrift_proxy: fix the thrift_proxy connection manager to correctly report success/error response metrics when performing :ref:`payload passthrough <envoy_v3_api_field_extensions.filters.network.thrift_proxy.v3.ThriftProxy.payload_passthrough>`.

Expand Down
4 changes: 4 additions & 0 deletions source/server/config_validation/server.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,8 @@
#include "envoy/config/bootstrap/v3/bootstrap.pb.h"

#include "source/common/common/utility.h"
#include "source/common/config/grpc_mux_impl.h"
#include "source/common/config/new_grpc_mux_impl.h"
#include "source/common/config/utility.h"
#include "source/common/event/real_time_system.h"
#include "source/common/local_info/local_info_impl.h"
Expand Down Expand Up @@ -123,6 +125,8 @@ void ValidationInstance::shutdown() {
config_.clusterManager()->shutdown();
}
thread_local_.shutdownThread();
Config::GrpcMuxImpl::shutdownAll();
Config::NewGrpcMuxImpl::shutdownAll();
dispatcher_->shutdown();
}

Expand Down