[Backport 1.20]Listener: fix a crash when updating any listener that does not bind t…#18505
Merged
mathetake merged 1 commit intoenvoyproxy:release/v1.20from Oct 18, 2021
Merged
Conversation
…o port (envoyproxy#18421) Signed-off-by: Yuchen Dai <silentdai@gmail.com>
Contributor
Author
|
/assign lizan |
lizan
approved these changes
Oct 7, 2021
Member
|
@mathetake as the stable release owner I assume that lizan's approval means that the backport is approved |
davinci26
added
backport/review
mathetake
approved these changes
Oct 18, 2021
Member
mathetake
left a comment
mathetake
left a comment
There was a problem hiding this comment.
LGTM (sorry for being late -- I had been OOO)
aidanhahn
pushed a commit
to gravitee-io/envoy
that referenced
this pull request
Jan 13, 2022
…o port (envoyproxy#18421) (envoyproxy#18505) backport e84987c to v1.20 Fix the crash caused by listener update when the any listener set bind_to_port to false. A listener does not bind to port has no io handle. close() already check it. Now add the check to isOpen(). Also the Tcp(or Udp)ListenSocket::duplicate() creates parent ListenSocketImpl Make it returning the derived ListenSocket, either TcpListenSocket or UdpListenSocket Signed-off-by: Yuchen Dai <silentdai@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…o port (#18421)
Commit Message:
backport e84987c to v1.20
Fix the crash caused by listener update when the any listener set bind_to_port to false.
A listener does not bind to port has no io handle. close() already check it.
Now add the check to isOpen().
Also the Tcp(or Udp)ListenSocket::duplicate() creates parent ListenSocketImpl
Make it returning the derived ListenSocket, either TcpListenSocket or UdpListenSocket
Additional Description:
Risk Level:
Testing: Unit test on duplicate. Integration test on bind_to_port.
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]