thread: Assert thread quiescence between tests#18495
Merged
davinci26 merged 5 commits intoenvoyproxy:mainfrom Oct 8, 2021
Merged
thread: Assert thread quiescence between tests#18495davinci26 merged 5 commits intoenvoyproxy:mainfrom
davinci26 merged 5 commits intoenvoyproxy:mainfrom
Conversation
Signed-off-by: Joshua Marantz <jmarantz@google.com>
Signed-off-by: Joshua Marantz <jmarantz@google.com>
davinci26
reviewed
Oct 7, 2021
Member
davinci26
left a comment
davinci26
left a comment
There was a problem hiding this comment.
thanks, one small comment regarding the function name.
Signed-off-by: Joshua Marantz <jmarantz@google.com>
Signed-off-by: Joshua Marantz <jmarantz@google.com>
Contributor
Author
|
/retest |
|
Retrying Azure Pipelines: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit Message: Adds assertions that any 'main threads' have completely quiesced between test methods. I am not certain this can be an issue given the rest of Envoy test infrastructure (e.g. memory leaks from unjoined threads), but testing this is essentially free, and it's hard to be certain.
This doesn't happen normally when I test on my machine, but maybe such a delayed closing out of a MainThread might be responsible for rare flakes.
Additional Description:
Risk Level: low (test changes only)
Testing: //test/...
Docs Changes: n/a
Release Notes: n/a
Platform Specific Features: n/a