Skip to content

deps: Add missing CPEs#18480

Merged
phlax merged 3 commits intoenvoyproxy:mainfrom
phlax:deps-cpes
Oct 7, 2021
Merged

deps: Add missing CPEs#18480
phlax merged 3 commits intoenvoyproxy:mainfrom
phlax:deps-cpes

Conversation

@phlax
Copy link
Copy Markdown
Member

@phlax phlax commented Oct 6, 2021

Signed-off-by: Ryan Northey ryan@synca.io

Commit Message: deps: Add missing CPEs
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Fixes commit #PR or SHA]
[Optional Deprecated:]
[Optional API Considerations:]

Signed-off-by: Ryan Northey <ryan@synca.io>
@repokitteh-read-only repokitteh-read-only bot added the deps Approval required for changes to Envoy's external dependencies label Oct 6, 2021
@repokitteh-read-only
Copy link
Copy Markdown

CC @envoyproxy/dependency-shepherds: Your approval is needed for changes made to (bazel/.*repos.*\.bzl)|(bazel/dependency_imports\.bzl)|(api/bazel/.*\.bzl)|(.*/requirements\.txt)|(.*\.patch).

🐱

Caused by: #18480 was opened by phlax.

see: more, trace.

@phlax
Copy link
Copy Markdown
Member Author

phlax commented Oct 6, 2021

not sure if these are all correct - but it throws up some issues

  • flatbuffers - looks genuine
  • wasmtime - hard to tell, not sure if this is the correct CPE

@moderation
Copy link
Copy Markdown
Contributor

This is great. @PiotrSikora @lizan for verifying the Wasmtime CPE

@moderation
Copy link
Copy Markdown
Contributor

/lgtm deps

@repokitteh-read-only repokitteh-read-only bot removed the deps Approval required for changes to Envoy's external dependencies label Oct 6, 2021
moderation
moderation previously approved these changes Oct 6, 2021
Copy link
Copy Markdown
Contributor

@moderation moderation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good with the change that @lizan suggests for wasmtime

@htuch
Copy link
Copy Markdown
Member

htuch commented Oct 7, 2021

LGTM modulo comment.

Signed-off-by: Ryan Northey <ryan@synca.io>
@repokitteh-read-only repokitteh-read-only bot added the deps Approval required for changes to Envoy's external dependencies label Oct 7, 2021
Signed-off-by: Ryan Northey <ryan@synca.io>
@phlax phlax removed the deps Approval required for changes to Envoy's external dependencies label Oct 7, 2021
@phlax phlax merged commit 3791753 into envoyproxy:main Oct 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants