Skip to content

deps: update cel-cpp#18423

Merged
mattklein123 merged 6 commits intoenvoyproxy:mainfrom
kyessenov:update_cel_10_04_21
Oct 7, 2021
Merged

deps: update cel-cpp#18423
mattklein123 merged 6 commits intoenvoyproxy:mainfrom
kyessenov:update_cel_10_04_21

Conversation

@kyessenov
Copy link
Copy Markdown
Contributor

@kyessenov kyessenov commented Oct 5, 2021

Signed-off-by: Kuat Yessenov kuat@google.com

Commit Message: update cel-cpp
Additional Description:
Risk Level: low
Testing: regression testing
Docs Changes: none
Release Notes:
Platform Specific Features:

Signed-off-by: Kuat Yessenov <kuat@google.com>
@repokitteh-read-only
Copy link
Copy Markdown

CC @envoyproxy/dependency-shepherds: Your approval is needed for changes made to (bazel/.*repos.*\.bzl)|(bazel/dependency_imports\.bzl)|(api/bazel/.*\.bzl)|(.*/requirements\.txt)|(.*\.patch).

🐱

Caused by: #18423 was opened by kyessenov.

see: more, trace.

@repokitteh-read-only repokitteh-read-only bot added the deps Approval required for changes to Envoy's external dependencies label Oct 5, 2021
Signed-off-by: Kuat Yessenov <kuat@google.com>
@mattklein123 mattklein123 self-assigned this Oct 5, 2021
Signed-off-by: Kuat Yessenov <kuat@google.com>
@kyessenov kyessenov requested a review from lizan as a code owner October 6, 2021 04:32
Signed-off-by: Kuat Yessenov <kuat@google.com>
@kyessenov
Copy link
Copy Markdown
Contributor Author

Windows build fails with compiler exit code 2. Is there way to get more information about why it fails to compile?

Signed-off-by: Kuat Yessenov <kuat@google.com>
@kyessenov
Copy link
Copy Markdown
Contributor Author

Per discussion: Google permits designated initializers from C++20 in C++17 clang. MSVC seems to reject them at C++17.

Signed-off-by: Kuat Yessenov <kuat@google.com>
@mattklein123 mattklein123 merged commit 3df9bfa into envoyproxy:main Oct 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

deps Approval required for changes to Envoy's external dependencies

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants