Skip to content

SIPProxy BUGFIX UT failure for fastbuild/debug #18303

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mattklein123 merged 1 commit into from
Sep 29, 2021
Merged

SIPProxy BUGFIX UT failure for fastbuild/debug #18303

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 2 additions & 8 deletions contrib/sip_proxy/filters/network/test/conn_manager_test.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -247,13 +247,6 @@ stat_prefix: egress
filter_->stats_.response_exception_.inc();
EXPECT_EQ(2U, filter_->stats_.response_exception_.value());
}
/*
// metadata = nullptr
std::string transid = trans->transactionId();
trans->metadata_ = nullptr;
filter_->transactions_.emplace(transid, std::move(trans));
filter_->transactions_.at(transid)->upstreamData(filter_->decoder_->metadata_);
*/

// transportEnd throw envoyException
filter_->read_callbacks_->connection().setDelayedCloseTimeout(std::chrono::milliseconds(1));
Expand All @@ -263,7 +256,8 @@ stat_prefix: egress
try {
ConnectionManager::ResponseDecoder response_decoder(*trans1);
response_decoder.newDecoderEventHandler(filter_->decoder_->metadata());
response_decoder.transportEnd();
// transportEnd throw envoyException
response_decoder.onData(filter_->decoder_->metadata());
} catch (const EnvoyException& ex) {
filter_->stats_.response_exception_.inc();
EXPECT_EQ(2U, filter_->stats_.response_exception_.value());
Expand Down