socket option: add new constructors to address aware impl#18281
Merged
mattklein123 merged 1 commit intomainfrom Sep 28, 2021
Merged
socket option: add new constructors to address aware impl#18281mattklein123 merged 1 commit intomainfrom
mattklein123 merged 1 commit intomainfrom
Conversation
Needed for Envoy Mobile. Signed-off-by: Matt Klein <mklein@lyft.com>
goaway
approved these changes
Sep 27, 2021
Contributor
goaway
left a comment
goaway
left a comment
There was a problem hiding this comment.
Thanks @mattklein123! Looks good on our end.
ggreenway
approved these changes
Sep 27, 2021
soulxu
pushed a commit
to soulxu/envoy
that referenced
this pull request
Oct 16, 2021
…#18281) Needed for Envoy Mobile. Signed-off-by: Matt Klein <mklein@lyft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Needed for Envoy Mobile.
Risk Level: Low
Testing: New UT
Docs Changes: N/A
Release Notes: N/A
Platform Specific Features: N/A