Merged
Conversation
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
danzh2010
reviewed
Sep 21, 2021
danzh2010
approved these changes
Sep 21, 2021
Contributor
danzh2010
left a comment
danzh2010
left a comment
There was a problem hiding this comment.
Thanks for cleaning up EXCLUDE_DOWNSTREAM_HTTP3!
mattklein123
approved these changes
Sep 23, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixing client side goaways to send (in opt mode) rather than crash.
In debug mode, this unfortunately still crashes due to an upstream quiche perspective check, so commenting that out and adding a TODO.
Risk Level: low
Testing: updated
Docs Changes: n/a
Release Notes: n/a
Fixes #12930