header-to-metadata: add option to apply an upstream TLS context override#18112
Closed
rgs1 wants to merge 8 commits intoenvoyproxy:mainfrom
Closed
header-to-metadata: add option to apply an upstream TLS context override#18112rgs1 wants to merge 8 commits intoenvoyproxy:mainfrom
rgs1 wants to merge 8 commits intoenvoyproxy:mainfrom
Conversation
Helps envoyproxy#17882. Signed-off-by: Raul Gutierrez Segales <rgs@pinterest.com>
added 7 commits
September 14, 2021 11:42
wbpcode
reviewed
Sep 15, 2021
| if (value && proto_rule.has_on_header_present()) { | ||
| applyKeyValue(std::move(value).value_or(""), rule, proto_rule.on_header_present(), | ||
| structs_by_namespace); | ||
| auto applied_value = applyKeyValue(std::move(value).value_or(""), rule, |
Member
There was a problem hiding this comment.
Do we need to use value_or() here?
Member
|
qq: does #17995 fit your use case? it allows to use a header value for san validation. |
|
This pull request has been automatically marked as stale because it has not had activity in the last 30 days. It will be closed in 7 days if no further activity occurs. Please feel free to give a status update now, ping for review, or re-open when it's ready. Thank you for your contributions! |
github-actions
bot
added
the
stale
Member
Author
Maybe – we could construct the header dynamically from another filter... cc: @fishcakez |
Member
Author
|
@lizan per @fishcakez we used that option in the end – thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Helps #17882.
Signed-off-by: Raul Gutierrez Segales rgs@pinterest.com