Docs: Fix Reset Stream documentation math formatting.#18102
Merged
phlax merged 1 commit intoenvoyproxy:mainfrom Sep 14, 2021
Merged
Docs: Fix Reset Stream documentation math formatting.#18102phlax merged 1 commit intoenvoyproxy:mainfrom
phlax merged 1 commit intoenvoyproxy:mainfrom
Conversation
Signed-off-by: Kevin Baichoo <kbaichoo@google.com>
Member
|
docs (will be) rendered here https://storage.googleapis.com/envoy-pr/18102/docs/index.html |
phlax
approved these changes
Sep 14, 2021
Member
phlax
left a comment
phlax
left a comment
There was a problem hiding this comment.
lgtm, thanks @KBaichoo
looking at the rendering im wondering if the math symbols would be better typeset as literals rather than italics, i can check the docs markup and see why its doing that, i dont think italics is the default (not sure)
tyxia
pushed a commit
to tyxia/envoy
that referenced
this pull request
Sep 21, 2021
…nvoyproxy#18102) Signed-off-by: Kevin Baichoo <kbaichoo@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Kevin Baichoo kbaichoo@google.com
Commit Message: Fix Reset Stream documentation w.r.t
math.Additional Description: Underscores
Risk Level: Docs only
Testing: See image
Docs Changes: Docs only
Release Notes: NA
Platform Specific Features: NA
Before:
After:
