Skip to content

Remove addFilter() #18097

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
rgs1 wants to merge 5 commits into from
Closed

Remove addFilter() #18097

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
8e3db4f
Remove addFilter()
Sep 13, 2021
e81b3c0
Merge remote-tracking branch 'upstream/main' into remove-add-filter
Sep 13, 2021
1de658c
Bump envoy-filter-example version.
Sep 13, 2021
fb0c0ef
Merge remote-tracking branch 'upstream/main' into remove-add-filter
Sep 13, 2021
a88a9bb
Merge remote-tracking branch 'upstream/main' into remove-add-filter
Sep 14, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ci/filter_example_setup.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
set -e

# This is the hash on https://github.com/envoyproxy/envoy-filter-example.git we pin to.
ENVOY_FILTER_EXAMPLE_GITSHA="ac6a66a4a1c08138ccc03c23aafc9637b2df55a1"
ENVOY_FILTER_EXAMPLE_GITSHA="85b7e0ed452f0987b480feb9cfe46abc914aca67"
ENVOY_FILTER_EXAMPLE_SRCDIR="${BUILD_DIR}/envoy-filter-example"

# shellcheck disable=SC2034
Expand Down
2 changes: 0 additions & 2 deletions test/config/utility.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1040,8 +1040,6 @@ void ConfigHelper::addVirtualHost(const envoy::config::route::v3::VirtualHost& v
storeHttpConnectionManager(hcm_config);
}

void ConfigHelper::addFilter(const std::string& config) { prependFilter(config); }

void ConfigHelper::prependFilter(const std::string& config) {
RELEASE_ASSERT(!finalized_, "");
envoy::extensions::filters::network::http_connection_manager::v3::HttpConnectionManager
Expand Down
4 changes: 0 additions & 4 deletions test/config/utility.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -215,10 +215,6 @@ class ConfigHelper {
// Add an HTTP filter prior to existing filters.
void prependFilter(const std::string& filter_yaml);

// Add an HTTP filter prior to existing filters.
// TODO(rgs1): remove once envoy-filter-example has been updated.
void addFilter(const std::string& filter_yaml);

// Add a network filter prior to existing filters.
void addNetworkFilter(const std::string& filter_yaml);

Expand Down