factory: cleaning up factory APIs to allow code sharing#18096
Merged
jmarantz merged 4 commits intoenvoyproxy:mainfrom Sep 14, 2021
Merged
factory: cleaning up factory APIs to allow code sharing#18096jmarantz merged 4 commits intoenvoyproxy:mainfrom
jmarantz merged 4 commits intoenvoyproxy:mainfrom
Conversation
…ments Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
Signed-off-by: Alyssa Wilk <alyssar@chromium.org>
jmarantz
reviewed
Sep 14, 2021
Contributor
jmarantz
left a comment
jmarantz
left a comment
There was a problem hiding this comment.
Nice refactor. One minor comment and I'm good to go.
| Server::Configuration::FactoryContextBase& context, | ||
| const envoy::extensions::common::dynamic_forward_proxy::v3::DnsCacheConfig& config) | ||
| : main_thread_dispatcher_(main_thread_dispatcher), | ||
| : main_thread_dispatcher_(context.dispatcher()), |
Contributor
There was a problem hiding this comment.
Suggest renaming FactoryContextBase::dispatcher() to FactoryContextBase::mainThreadDispatcher to make it clearer that there can be lots of dispatchers but this is the one for the main thread.
Contributor
Author
There was a problem hiding this comment.
Happy to do this but would you be Ok with a follow-up? I suspect it's going to be significant churn.
Contributor
There was a problem hiding this comment.
sgtm wasn't aware there would be that much, but this is fine.
jmarantz
approved these changes
Sep 14, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clean up inspired by #17745
Risk Level: low (interface refactor)
Testing: n/a
Docs Changes: n/a
Release Notes: n/a