bazel: Add json_data and writers#18086
Merged
htuch merged 2 commits intoenvoyproxy:mainfrom Sep 15, 2021
Merged
Conversation
phlax
force-pushed
the
bazel-json-data
branch
from
2570d99 to
a6c37b3
Compare
phlax
force-pushed
the
bazel-json-data
branch
3 times, most recently
from
9627f43 to
9e974eb
Compare
Signed-off-by: Ryan Northey <ryan@synca.io>
phlax
force-pushed
the
bazel-json-data
branch
from
9e974eb to
171f37f
Compare
phlax
commented
Sep 12, 2021
| ] | ||
| for d in api_dirs: | ||
| ctx.symlink(ctx.path(ctx.attr.envoy_root).dirname.get_child(ctx.attr.reldir).get_child(d), d) | ||
| ctx.symlink(ctx.path(ctx.attr.envoy_root).dirname.get_child("bazel").get_child("utils.bzl"), "utils.bzl") |
Member
Author
There was a problem hiding this comment.
ive tried a few different ways to make the json_data macro available in the api part of the repo
not sure the best way
Member
There was a problem hiding this comment.
Possibly the cleanest way is to put the json_data macro inside api/bazel. That makes the dependency chain simpler.
Member
Author
There was a problem hiding this comment.
not sure why i didnt think of that - ill move it
phlax
changed the title
json_data and providersjson_data and writers
htuch
previously approved these changes
Sep 13, 2021
| ] | ||
| for d in api_dirs: | ||
| ctx.symlink(ctx.path(ctx.attr.envoy_root).dirname.get_child(ctx.attr.reldir).get_child(d), d) | ||
| ctx.symlink(ctx.path(ctx.attr.envoy_root).dirname.get_child("bazel").get_child("utils.bzl"), "utils.bzl") |
Member
There was a problem hiding this comment.
Possibly the cleanest way is to put the json_data macro inside api/bazel. That makes the dependency chain simpler.
Signed-off-by: Ryan Northey <ryan@synca.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ryan Northey ryan@synca.io
Commit Message: bazel: Add json_data and providers
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Deprecated:]
[Optional API Considerations:]