Skip to content

tools: fix print dependencies#18084

Merged
phlax merged 1 commit intoenvoyproxy:mainfrom
wbpcode:fix-print-deps
Sep 14, 2021
Merged

tools: fix print dependencies#18084
phlax merged 1 commit intoenvoyproxy:mainfrom
wbpcode:fix-print-deps

Conversation

@wbpcode
Copy link
Copy Markdown
Member

@wbpcode wbpcode commented Sep 11, 2021

Signed-off-by: wbpcode wbphub@live.com

Commit Message: tools: fix print dependencies
Additional Description:

Fix broken python script that used to print dependencies.

Risk Level: N/A.
Testing: N/A.
Docs Changes: N/A.
Release Notes: N/A.
Platform Specific Features: N/A.

Signed-off-by: wbpcode <wbphub@live.com>
@phlax
Copy link
Copy Markdown
Member

phlax commented Sep 11, 2021

hi @wbpcode see #17998 for an alternate approach to cleaning these up

Copy link
Copy Markdown
Member

@phlax phlax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks @wbpcode

@phlax phlax merged commit 9c78929 into envoyproxy:main Sep 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants