router: add per_try_idle_timeout configuration#18078
Merged
mattklein123 merged 4 commits intomainfrom Sep 14, 2021
Merged
Conversation
Allows ensuring continual progress of individual request attempts. Signed-off-by: Matt Klein <mklein@lyft.com>
|
CC @envoyproxy/api-shepherds: Your approval is needed for changes made to |
Signed-off-by: Matt Klein <mklein@lyft.com>
alyssawilk
reviewed
Sep 14, 2021
Contributor
alyssawilk
left a comment
alyssawilk
left a comment
There was a problem hiding this comment.
Looks good overall! Just 2 nits/questions
|
|
||
| void UpstreamRequest::onPerTryIdleTimeout() { | ||
| ENVOY_STREAM_LOG(debug, "upstream per try idle timeout", *parent_.callbacks()); | ||
| stream_info_.setResponseFlag(StreamInfo::ResponseFlag::StreamIdleTimeout); |
Contributor
There was a problem hiding this comment.
If there's 2 tries (hedging or retries) but we successfully proxy, should the response flag be set?
Member
Author
There was a problem hiding this comment.
This is stream info on the upstream request (for upstream logs), not the downstream stream info.
adisuissa
reviewed
Sep 14, 2021
Contributor
adisuissa
left a comment
adisuissa
left a comment
There was a problem hiding this comment.
Thanks!
Left a couple of API comments
Signed-off-by: Matt Klein <mklein@lyft.com>
alyssawilk
approved these changes
Sep 14, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Allows ensuring continual progress of individual request attempts.
Risk Level: Low when not using feature. Medium when using feature. Timeouts are scary.
Testing: Unit and integration.
Docs Changes: Added
Release Notes: Added
Platform Specific Features: N/A