Skip to content

kafka: upgrade kafka source code and server dependencies to 2.8.1#18074

Merged
mattklein123 merged 11 commits intoenvoyproxy:mainfrom
adamkotwasinski:kafka-server-28-upgrade
Sep 23, 2021
Merged

kafka: upgrade kafka source code and server dependencies to 2.8.1#18074
mattklein123 merged 11 commits intoenvoyproxy:mainfrom
adamkotwasinski:kafka-server-28-upgrade

Conversation

@adamkotwasinski
Copy link
Copy Markdown
Contributor

@adamkotwasinski adamkotwasinski commented Sep 10, 2021

Commit Message: kafka: upgrade kafka source code and server dependencies to 2.8.1
Additional Description: as per #17260 (comment) upgrade the dependencies; also get rid of source patch in favour of processing in python script
There are some minor changes in mesh code due to Kafka protocol spec files changing field names a little (e.g. this vs this), but it does not impact the protocol's functioning (it's the same bytes after all - we just reference them differently).
Risk Level: Low
Testing: integration tests (server versions: 2.4.1, 2.8.1), manual tests for broker-filter (client=2.5.1 + server=2.4.0; client=2.8.1 + server=2.8.1), manual tests for mesh-filter (client=2.4.1; client=2.8.1; server=2.8.1)
Docs Changes: Minor .rst updates (because Kafka versions are explicitly mentioned there)
Release Notes: N/A
Platform Specific Features: N/A

@repokitteh-read-only
Copy link
Copy Markdown

As a reminder, PRs marked as draft will not be automatically assigned reviewers,
or be handled by maintainer-oncall triage.

Please mark your PR as ready when you want it to be reviewed!

🐱

Caused by: #18074 was opened by adamkotwasinski.

see: more, trace.

@repokitteh-read-only
Copy link
Copy Markdown

CC @envoyproxy/dependency-shepherds: Your approval is needed for changes made to (bazel/.*repos.*\.bzl)|(bazel/dependency_imports\.bzl)|(api/bazel/.*\.bzl)|(.*/requirements\.txt)|(.*\.patch).

🐱

Caused by: #18074 was opened by adamkotwasinski.

see: more, trace.

@repokitteh-read-only repokitteh-read-only bot added the deps Approval required for changes to Envoy's external dependencies label Sep 10, 2021
@moderation
Copy link
Copy Markdown
Contributor

@adamkotwasinski
Copy link
Copy Markdown
Contributor Author

@moderation
yes - it's a draft right now, because 2.5 and further ones added new data types so I need to write some more C++ code (uuid, records, float64)
I'd rather do only this one https://github.com/envoyproxy/envoy/blob/main/bazel/repository_locations.bzl#L931 in this PR, because it's going to be noisy anyways ; other ones will follow independently

…or script

Signed-off-by: Adam Kotwasinski <adam.kotwasinski@gmail.com>
Signed-off-by: Adam Kotwasinski <adam.kotwasinski@gmail.com>
Signed-off-by: Adam Kotwasinski <adam.kotwasinski@gmail.com>
… some args being optional now

Signed-off-by: Adam Kotwasinski <adam.kotwasinski@gmail.com>
Signed-off-by: Adam Kotwasinski <adam.kotwasinski@gmail.com>
Comment on lines +933 to +934
version = "2.8.1-rc1",
sha256 = "4f013aadedd0c26c31c67bc8f3984833430316fa990553ded77dfbaa65f43376",
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Signed-off-by: Adam Kotwasinski <adam.kotwasinski@gmail.com>
Signed-off-by: Adam Kotwasinski <adam.kotwasinski@gmail.com>
Signed-off-by: Adam Kotwasinski <adam.kotwasinski@gmail.com>
@moderation
Copy link
Copy Markdown
Contributor

moderation commented Sep 21, 2021

Signed-off-by: Adam Kotwasinski <adam.kotwasinski@gmail.com>
Signed-off-by: Adam Kotwasinski <adam.kotwasinski@gmail.com>
@repokitteh-read-only
Copy link
Copy Markdown

Retrying Azure Pipelines:
Check envoy-presubmit isn't fully completed, but will still attempt retrying.
Retried failed jobs in: envoy-presubmit

🐱

Caused by: a #18074 (comment) was created by @adamkotwasinski.

see: more, trace.

@repokitteh-read-only
Copy link
Copy Markdown

Retrying Azure Pipelines:
Retried failed jobs in: envoy-presubmit

🐱

Caused by: a #18074 (comment) was created by @adamkotwasinski.

see: more, trace.

@adamkotwasinski adamkotwasinski changed the title [WIP] kafka: upgrade kafka-server dependency to 2.8 kafka: upgrade kafka source code & server dependencies to 2.8.1 Sep 22, 2021
@adamkotwasinski adamkotwasinski changed the title kafka: upgrade kafka source code & server dependencies to 2.8.1 kafka: upgrade kafka source code and server dependencies to 2.8.1 Sep 22, 2021
@adamkotwasinski
Copy link
Copy Markdown
Contributor Author

source-code (for generating parser code) and server (for integration tests) dependencies have been updated to 2.8.1
what's coming in the future: update to 3.x (not doing this time to avoid pulling even more noise) and dpkp-kafka-python / librdkafka ones

@adamkotwasinski adamkotwasinski marked this pull request as ready for review September 22, 2021 21:29
Signed-off-by: Adam Kotwasinski <adam.kotwasinski@gmail.com>
@alyssawilk
Copy link
Copy Markdown
Contributor

/assign-from @envoyproxy/dependency-shepherds

@repokitteh-read-only
Copy link
Copy Markdown

@envoyproxy/dependency-shepherds assignee is @mattklein123

🐱

Caused by: a #18074 (comment) was created by @alyssawilk.

see: more, trace.

@mattklein123 mattklein123 merged commit a491e09 into envoyproxy:main Sep 23, 2021
@adamkotwasinski adamkotwasinski deleted the kafka-server-28-upgrade branch September 23, 2021 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

deps Approval required for changes to Envoy's external dependencies

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants