Update QUICHE to e8ddc3873182355137862b4d6417add2b2b8a31d#18060
Update QUICHE to e8ddc3873182355137862b4d6417add2b2b8a31d#18060ggreenway merged 2 commits intoenvoyproxy:mainfrom
Conversation
repokitteh-read-only
bot
added
the
deps
Signed-off-by: David Schinazi <dschinazi@google.com>
DavidSchinazi
force-pushed
the
quiche_roll_20210909
branch
from
931874d to
14a47b4
Compare
Signed-off-by: David Schinazi <dschinazi@google.com>
|
/lgtm deps |
repokitteh-read-only
bot
removed
the
deps
|
/assign @danzh2010 |
|
/retest |
|
Retrying Azure Pipelines: |
danzh2010
left a comment
danzh2010
left a comment
There was a problem hiding this comment.
LGTM, thanks for the update!
|
/assign @envoyproxy/envoy-maintainers |
|
@envoyproxy/envoy-maintainers cannot be assigned to this issue. |
|
/assign @ggreenway |
|
@DavidSchinazi small nit: do you mind updating the title to indicate the direction of the roll so its easier to understand from the commit log. I.e. update QUICE to |
DavidSchinazi
changed the title
|
Done |
ggreenway
left a comment
ggreenway
left a comment
There was a problem hiding this comment.
Is there anything specific we're picking up in this update, or just keeping up-to-date?
| const std::string& hostname) { | ||
| const std::string& hostname, bool* cert_matched_sni) { | ||
| // TODO(DavidSchinazi) parse the certificate to correctly fill in |cert_matched_sni|. | ||
| *cert_matched_sni = false; |
There was a problem hiding this comment.
What's the impact of setting this to false?
There was a problem hiding this comment.
There isn't any, the core library simply plumbs this value through (another user needed it) and Envoy doesn't read it on the other side so this is a no-op
DavidSchinazi
left a comment
DavidSchinazi
left a comment
There was a problem hiding this comment.
This is just us keeping up with upstream QUICHE, no particularly interesting features to report.
| const std::string& hostname) { | ||
| const std::string& hostname, bool* cert_matched_sni) { | ||
| // TODO(DavidSchinazi) parse the certificate to correctly fill in |cert_matched_sni|. | ||
| *cert_matched_sni = false; |
There was a problem hiding this comment.
There isn't any, the core library simply plumbs this value through (another user needed it) and Envoy doesn't read it on the other side so this is a no-op
5 participants
Commit Message: Update QUICHE to e8ddc3873182355137862b4d6417add2b2b8a31d
Additional Description: None
Risk Level: Low
Testing: Local
Docs Changes: None
Release Notes: None
Platform Specific Features: None