tests: rename addFilter() to prependFilter()#18059
Merged
yanavlasov merged 10 commits intoenvoyproxy:mainfrom Sep 11, 2021
Merged
tests: rename addFilter() to prependFilter()#18059yanavlasov merged 10 commits intoenvoyproxy:mainfrom
yanavlasov merged 10 commits intoenvoyproxy:mainfrom
Conversation
To avoid confusion when writing integration tests, make it clear that filters are prepended. Signed-off-by: Raul Gutierrez Segales <rgs@pinterest.com>
rgs1
requested review from
alyssawilk,
antoniovicente,
asraa,
dio,
htuch,
jmarantz,
lizan,
mattklein123,
rojkov,
snowp and
zuercher
as code owners
added 2 commits
September 9, 2021 19:46
Signed-off-by: Raul Gutierrez Segales <rgs@pinterest.com>
rojkov
reviewed
Sep 10, 2021
Member
rojkov
left a comment
rojkov
left a comment
There was a problem hiding this comment.
Thanks! This way it's clearer indeed.
added 6 commits
September 10, 2021 10:43
Signed-off-by: Raul Gutierrez Segales <rgs@pinterest.com>
We can remove it after this lands and the envoy-filter-example repo is updated, since we can't update both repos atomically. Signed-off-by: Raul Gutierrez Segales <rgs@pinterest.com>
Signed-off-by: Raul Gutierrez Segales <rgs@pinterest.com>
Signed-off-by: Raul Gutierrez Segales <rgs@pinterest.com>
Member
|
/assign-from @envoyproxy/envoy-maintainers |
|
@envoyproxy/envoy-maintainers assignee is @yanavlasov |
yanavlasov
approved these changes
Sep 11, 2021
Member
Author
|
Counterpart: |
rgs1
pushed a commit
to rgs1/envoy
that referenced
this pull request
Sep 13, 2021
Follow up to envoyproxy#18059. This can land after: envoyproxy/envoy-filter-example#151 Signed-off-by: Raul Gutierrez Segales <rgs@pinterest.com>
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To avoid confusion when writing integration tests, make it clear
that filters are prepended.
It's currently an addition not an actual rename, because the rename would
break the envoy-filter-example repo and the ASAN/TSAN tests rely on
that. So I'll get rid of addFilter() after this lands and the example repo
is updated.
Signed-off-by: Raul Gutierrez Segales rgs@pinterest.com