Skip to content

Wrong past participle words fixed in comments #18037

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
phlax merged 2 commits into from
Sep 10, 2021
Merged

Wrong past participle words fixed in comments #18037

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b2d3b08
Wrong past participle words fixed in comments
Sep 9, 2021
eb778ac
Change the text to disambiguate
Sep 10, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion envoy/server/overload/overload_manager.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,7 @@ using OverloadActionNames = ConstSingleton<OverloadActionNameValues>;
*/
class OverloadActionStatsNameValues {
public:
// Count of ther number of streams the reset streams action has reset
// Count of the number of streams the reset streams action has reset
Copy link
Copy Markdown
Member

@phlax phlax Sep 9, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wow this is wordy 8/

const std::string ResetStreamsCount = "envoy.overload_actions.reset_high_memory_stream.count";
};

Expand Down
11 changes: 6 additions & 5 deletions envoy/stats/allocator.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,11 +70,12 @@ class Allocator {
virtual void markTextReadoutForDeletion(const TextReadoutSharedPtr& text_readout) PURE;

/**
* Iterate over all stats that need to be sinked. Note, that implementations can potentially hold
* on to a mutex that will deadlock if the passed in functors try to create or delete a stat.
* @param f_size functor that is provided the number of all sinked stats. Note this is called
* only once, prior to any calls to f_stat.
* @param f_stat functor that is provided one sinked stat at a time.
* Iterate over all stats that need to be added to a sink. Note, that implementations can
* potentially hold on to a mutex that will deadlock if the passed in functors try to create
* or delete a stat.
* @param f_size functor that is provided the number of all stats in the sink. Note this is
* called only once, prior to any calls to f_stat.
* @param f_stat functor that is provided one stat in the sink at a time.
*/
virtual void forEachCounter(std::function<void(std::size_t)> f_size,
std::function<void(Stats::Counter&)> f_stat) const PURE;
Expand Down
9 changes: 5 additions & 4 deletions envoy/stats/store.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,10 +51,11 @@ class Store : public Scope {
virtual std::vector<ParentHistogramSharedPtr> histograms() const PURE;

/**
* Iterate over all stats that need to be sinked. Note, that implementations can potentially hold
* on to a mutex that will deadlock if the passed in functors try to create or delete a stat.
* @param f_size functor that is provided the number of all sinked stats.
* @param f_stat functor that is provided one sinked stat at a time.
* Iterate over all stats that need to be added to a sink. Note, that implementations can
* potentially hold on to a mutex that will deadlock if the passed in functors try to create
* or delete a stat.
* @param f_size functor that is provided the number of all stats in the sink.
* @param f_stat functor that is provided one stat in the sink at a time.
*/
virtual void forEachCounter(std::function<void(std::size_t)> f_size,
std::function<void(Stats::Counter&)> f_stat) const PURE;
Expand Down