bazel: Add implementation of ABazelQuery#18021
Merged
phlax merged 3 commits intoenvoyproxy:mainfrom Sep 16, 2021
Merged
Conversation
repokitteh-read-only
bot
added
the
deps
phlax
force-pushed
the
bazel-query
branch
5 times, most recently
from
7bbf856 to
0b2d21d
Compare
Signed-off-by: Ryan Northey <ryan@synca.io>
phlax
changed the title
htuch
reviewed
Sep 15, 2021
Member
Author
|
/wait for docstring/commenting |
Signed-off-by: Ryan Northey <ryan@synca.io>
phlax
commented
Sep 15, 2021
Signed-off-by: Ryan Northey <ryan@synca.io>
htuch
approved these changes
Sep 15, 2021
Member
htuch
left a comment
htuch
left a comment
There was a problem hiding this comment.
LGTM, with the caveat again that hiding this path stuff from the wrapper is ideal.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit Message: bazel: Add implementation of ABazelQuery
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Deprecated:]
[Optional API Considerations:]