Skip to content

Revert "listener: create per network filter chain stats scope (#17931)"#18017

Merged
mattklein123 merged 1 commit intoenvoyproxy:mainfrom
lambdai:omain
Sep 8, 2021
Merged

Revert "listener: create per network filter chain stats scope (#17931)"#18017
mattklein123 merged 1 commit intoenvoyproxy:mainfrom
lambdai:omain

Conversation

@lambdai
Copy link
Copy Markdown
Contributor

@lambdai lambdai commented Sep 8, 2021

Commit Message:
Crash is reported.

Additional Description:

Risk Level: LOW. Stats may leak and no worse than a week back.
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Deprecated:]
[Optional API Considerations:]

…roxy#17931)"

This reverts commit c361b05.

Signed-off-by: Yuchen Dai <silentdai@gmail.com>
@lambdai
Copy link
Copy Markdown
Contributor Author

lambdai commented Sep 8, 2021

/assign @mattklein123

@lambdai
Copy link
Copy Markdown
Contributor Author

lambdai commented Sep 8, 2021

/retest

@repokitteh-read-only
Copy link
Copy Markdown

Retrying Azure Pipelines:
Retried failed jobs in: envoy-presubmit

🐱

Caused by: a #18017 (comment) was created by @lambdai.

see: more, trace.

Copy link
Copy Markdown
Member

@mattklein123 mattklein123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@mattklein123 mattklein123 merged commit 9f5e9fb into envoyproxy:main Sep 8, 2021
@lambdai lambdai deleted the omain branch September 8, 2021 18:25
tyxia pushed a commit to tyxia/envoy that referenced this pull request Sep 21, 2021
…roxy#17931)" (envoyproxy#18017)

This reverts commit c361b05.

Signed-off-by: Yuchen Dai <silentdai@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants