docs: fix bazelisk installation command for linux/arm64#18016
Merged
lizan merged 1 commit intoenvoyproxy:mainfrom Sep 8, 2021
musaprg:patch-1
Merged
docs: fix bazelisk installation command for linux/arm64#18016lizan merged 1 commit intoenvoyproxy:mainfrom musaprg:patch-1
lizan merged 1 commit intoenvoyproxy:mainfrom
musaprg:patch-1
Conversation
In aarch64 machines, the bazelisk installation command fails due to binary format mismatch. We need to take care of the architecture running on. Signed-off-by: Kotaro Inoue <k.musaino@gmail.com>
tyxia
pushed a commit
to tyxia/envoy
that referenced
this pull request
Sep 21, 2021
In aarch64 machines, the bazelisk installation command fails due to binary format mismatch. We need to take care of the architecture running on. Signed-off-by: Kotaro Inoue <k.musaino@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In aarch64 machines, the bazelisk installation command in the docs fails due to binary format mismatch.
This change is not critical for users because they can notice it before or after invoking it, but for convenience, this PR fixes the command to take care of the machine architecture running on.
Since the bazelisk is written in Go and anyway the Go is needed to build BoringSSL, it might be better to use
go installorgo get -ucommand to install bazelisk to avoid tricky oneliner install command. Please take a look and give some comments about it.Risk Level: Low
Testing: N/A
Docs Changes: fix the bazelisk installation command for Linux in
bazel/README.mdto take care of its running arch.Release Notes: N/A