dubbo: fix dubbo heart beat response#18001
Merged
zuercher merged 4 commits intoenvoyproxy:mainfrom Sep 7, 2021
Merged
Conversation
Signed-off-by: wbpcode <wbphub@live.com>
Signed-off-by: wbpcode <wbphub@live.com>
rojkov
reviewed
Sep 7, 2021
|
|
||
| Buffer::OwnedImpl buffer; | ||
| DubboProtocolImpl dubbo_protocol; | ||
| EXPECT_TRUE(dubbo_protocol.encode(buffer, metadata, "")); |
Member
There was a problem hiding this comment.
Looks like an rpc response type is missing in dubbo_protocol.encode().
tyxia
pushed a commit
to tyxia/envoy
that referenced
this pull request
Sep 21, 2021
Risk Level: low Testing: Added. Fixes Issue: envoyproxy#17996 Docs Changes: N/A. Release Notes: N/A. Platform Specific Features: N/A. Signed-off-by: wbpcode <wbphub@live.com> Signed-off-by: code <wbpcode@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: wbpcode wbphub@live.com
Fix dubbo heart beat response. #17996
Commit Message: dubbo: fix dubbo heart beat response
Additional Description:
Risk Level: Low.
Testing: Added.
Docs Changes: N/A.
Release Notes: N/A.
Platform Specific Features: N/A.