tooling: Fix sync_assignable#17997
Merged
mattklein123 merged 1 commit intoenvoyproxy:mainfrom Sep 10, 2021
Merged
Conversation
repokitteh-read-only
bot
added
the
deps
phlax
force-pushed
the
tooling-sync-assigned
branch
3 times, most recently
from
b1c0a7f to
d6dc760
Compare
Member
Author
|
this probs conflicts with #17984 - i would prefer that one first |
Member
|
/assign @envoyproxy/dependency-shepherds |
|
@envoyproxy/dependency-shepherds cannot be assigned to this issue. |
Contributor
|
/lgtm deps |
repokitteh-read-only
bot
removed
the
deps
Member
Member
Author
|
@zuercher yep i reckon so (ie move forward with this one) |
Member
Author
|
actually, the other is unblocked and im guessing this tool is rarely used so probs better to wait |
Member
|
/wait |
phlax
force-pushed
the
tooling-sync-assigned
branch
from
d6dc760 to
087668d
Compare
Signed-off-by: Ryan Northey <ryan@synca.io>
phlax
force-pushed
the
tooling-sync-assigned
branch
from
087668d to
0482f07
Compare
Member
Author
|
@zuercher apologies for force push, most of the original changes were rebased out or not required |
zuercher
approved these changes
Sep 10, 2021
Member
zuercher
left a comment
zuercher
left a comment
There was a problem hiding this comment.
I assume the build failures are unrelated?
Member
Author
yep, fix just landed on main, ill rerun... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ryan Northey ryan@synca.io
Commit Message: tooling: Fix sync_assignable
Additional Description:
This lib lost its github dependency mostly as it uses a venv.
This shifts it to bazel and fixes the required dependencies
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Deprecated:]
[Optional API Considerations:]