lua: Fix printing Lua string containing hex characters by Patrick0308 · Pull Request #17994 · envoyproxy/envoy

Patrick0308 · 2021-09-06T03:29:22Z

Commit Message: Fix printing Lua string containing hex characters.
Additional Description:
Risk Level: Low
Testing: Unit test
Docs Changes: N/A
Release Notes: Added

Fixes #17975

Signed-off-by: Patrick patrickjiang0530@gmail.com

repokitteh-read-only · 2021-09-06T03:29:25Z

Hi @Patrick0308, welcome and thank you for your contribution.

We will try to review your Pull Request as quickly as possible.

In the meantime, please take a look at the contribution guidelines if you have not done so already.

🐱

Caused by: #17994 was opened by Patrick0308.

see: more, trace.

Signed-off-by: chaojiang <chao.jiang@longbridge.sg> Signed-off-by: Patrick <patrickjiang0530@gmail.com>

Signed-off-by: Patrick <patrickjiang0530@gmail.com>

Patrick0308 · 2021-09-06T04:25:13Z

@wbpcode PTAL

wbpcode · 2021-09-06T05:27:54Z

/assign

wbpcode

Thanks. This is looks great. And I added some comments.

source/extensions/filters/common/lua/wrappers.cc

Signed-off-by: Patrick <patrickjiang0530@gmail.com>

Patrick0308 · 2021-09-07T06:08:16Z

@wbpcode PTAL

wbpcode

Looks great. Thanks for your contribution. Just some new comments. And we also need to format codes with tools/code_format/check_format.py fix.

source/extensions/filters/common/lua/lua.h

test/extensions/filters/http/lua/lua_filter_test.cc

wbpcode · 2021-09-07T10:27:22Z

In addition, try not to use force push. Force push is not friendly to reviewers 🤣 . Thanks.

Patrick0308 · 2021-09-07T10:49:38Z

@wbpcode Sorry, I pushed force because I forget sign off.

Signed-off-by: Patrick <patrickjiang0530@gmail.com>

Patrick0308 · 2021-09-08T05:37:58Z

@wbpcode PTAL

wbpcode · 2021-09-08T06:42:47Z

/retest

repokitteh-read-only · 2021-09-08T06:42:51Z

Retrying Azure Pipelines:
Retried failed jobs in: envoy-presubmit

🐱

Caused by: a #17994 (comment) was created by @wbpcode.

see: more, trace.

source/extensions/filters/common/lua/wrappers.h

source/extensions/filters/common/lua/lua.h

Signed-off-by: Patrick <patrickjiang0530@gmail.com>

dio · 2021-09-08T21:37:56Z

/retest

repokitteh-read-only · 2021-09-08T21:38:00Z

Retrying Azure Pipelines:
Retried failed jobs in: envoy-presubmit

🐱

Caused by: a #17994 (comment) was created by @dio.

see: more, trace.

Patrick0308 · 2021-09-13T14:44:41Z

Sorry, I made a mistake when resolving conflict. It requested review from many people.

Signed-off-by: Patrick <patrickjiang0530@gmail.com>

dio · 2021-09-13T20:26:03Z

/retest

repokitteh-read-only · 2021-09-13T20:26:07Z

Retrying Azure Pipelines:
Retried failed jobs in: envoy-presubmit

🐱

Caused by: a #17994 (comment) was created by @dio.

see: more, trace.

dio

Thank you!

wbpcode · 2021-09-15T02:11:05Z

Thanks. Waiting @envoyproxy/senior-maintainers for a second review.

mattklein123

Thanks!

Patrick0308 force-pushed the fix-luaSetBytes branch from dd013e1 to ce4f00f Compare September 6, 2021 03:51

fix luaSetBytes as char

35c1bb7

Signed-off-by: chaojiang <chao.jiang@longbridge.sg> Signed-off-by: Patrick <patrickjiang0530@gmail.com>

Patrick0308 force-pushed the fix-luaSetBytes branch from ce4f00f to 35c1bb7 Compare September 6, 2021 03:53

fix lua script log be truncated

ca56457

Signed-off-by: Patrick <patrickjiang0530@gmail.com>

Patrick0308 changed the title ~~lua: fix string be truncated (WIP)~~ lua: fix string be truncated Sep 6, 2021

repokitteh-read-only bot assigned wbpcode Sep 6, 2021

wbpcode requested changes Sep 6, 2021

View reviewed changes

source/extensions/filters/common/lua/wrappers.cc Outdated Show resolved Hide resolved

add a checkLuaStringWithLength function

3eccad4

Signed-off-by: Patrick <patrickjiang0530@gmail.com>

Patrick0308 force-pushed the fix-luaSetBytes branch from 2c029f9 to 3eccad4 Compare September 7, 2021 06:07

Patrick0308 requested a review from wbpcode September 7, 2021 10:06

wbpcode requested changes Sep 7, 2021

View reviewed changes

source/extensions/filters/common/lua/lua.h Outdated Show resolved Hide resolved

test/extensions/filters/http/lua/lua_filter_test.cc Show resolved Hide resolved

Patrick0308 added 2 commits September 7, 2021 19:13

format code and modify comment

559ba90

Signed-off-by: Patrick <patrickjiang0530@gmail.com>

add test setBytes with empty string

468c0c5

Signed-off-by: Patrick <patrickjiang0530@gmail.com>

Patrick0308 requested a review from wbpcode September 7, 2021 11:32

Patrick0308 added 2 commits September 8, 2021 11:31

fix httpCall test failed

50dcaca

Signed-off-by: Patrick <patrickjiang0530@gmail.com>

add unit test for zero byte

141afac

Signed-off-by: Patrick <patrickjiang0530@gmail.com>

dio reviewed Sep 8, 2021

View reviewed changes

source/extensions/filters/common/lua/wrappers.h Outdated Show resolved Hide resolved

dio reviewed Sep 8, 2021

View reviewed changes

source/extensions/filters/common/lua/lua.h Outdated Show resolved Hide resolved

modify comment and function name

7785a54

Signed-off-by: Patrick <patrickjiang0530@gmail.com>

Patrick0308 requested review from mattklein123, rojkov, snowp, yanavlasov and zuercher as code owners September 13, 2021 14:40

Patrick0308 force-pushed the fix-luaSetBytes branch from 6cdc668 to aa6ff26 Compare September 13, 2021 14:42

Patrick0308 added 2 commits September 13, 2021 22:45

Merge remote-tracking branch 'upstream/main' into fix-luaSetBytes

d33d446

modify doc

3af7a01

Signed-off-by: Patrick <patrickjiang0530@gmail.com>

dio removed request for alyssawilk, antoniovicente, asraa, ggreenway, htuch, jmarantz, lizan, mathetake, mattklein123, rojkov, snowp, yanavlasov and zuercher September 13, 2021 20:26

dio approved these changes Sep 14, 2021

View reviewed changes

mattklein123 approved these changes Sep 15, 2021

View reviewed changes

mattklein123 merged commit 329b429 into envoyproxy:main Sep 15, 2021

Patrick0308 deleted the fix-luaSetBytes branch October 9, 2021 11:16

Patrick0308 mentioned this pull request Jul 18, 2022

Memory leak as a Istio sidecar #22218

Closed

Conversation

Patrick0308 commented Sep 6, 2021 • edited by dio Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

repokitteh-read-only bot commented Sep 6, 2021

Uh oh!

Patrick0308 commented Sep 6, 2021

Uh oh!

wbpcode commented Sep 6, 2021

Uh oh!

wbpcode left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Patrick0308 commented Sep 7, 2021

Uh oh!

wbpcode left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

wbpcode commented Sep 7, 2021

Uh oh!

Patrick0308 commented Sep 7, 2021

Uh oh!

Patrick0308 commented Sep 8, 2021

Uh oh!

wbpcode commented Sep 8, 2021

Uh oh!

repokitteh-read-only bot commented Sep 8, 2021

Uh oh!

Uh oh!

Uh oh!

dio commented Sep 8, 2021

Uh oh!

repokitteh-read-only bot commented Sep 8, 2021

Uh oh!

Patrick0308 commented Sep 13, 2021

Uh oh!

dio commented Sep 13, 2021

Uh oh!

repokitteh-read-only bot commented Sep 13, 2021

Uh oh!

dio left a comment

Choose a reason for hiding this comment

Uh oh!

wbpcode commented Sep 15, 2021

Uh oh!

mattklein123 left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

Patrick0308 commented Sep 6, 2021 •

edited by dio

Loading