Skip to content

Remove the deprecated test for deprecated_disable_overprovisioning #17916

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
htuch merged 1 commit into from
Sep 3, 2021
Merged

Remove the deprecated test for deprecated_disable_overprovisioning #17916

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 0 additions & 23 deletions test/common/config/opaque_resource_decoder_impl_test.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,29 +68,6 @@ TEST_F(OpaqueResourceDecoderImplTest, ValidateIgnored) {
EXPECT_EQ("fare", resource_decoder_.resourceName(*decoded_resource));
}

// Handling of smuggled deprecated fields during Any conversion.
TEST_F(OpaqueResourceDecoderImplTest, HiddenEnvoyDeprecatedFields) {
// This test is only valid in API-v3, and should be updated for API-v4
envoy::config::endpoint::v3::ClusterLoadAssignment cluster_load_assignment =
TestUtility::parseYaml<envoy::config::endpoint::v3::ClusterLoadAssignment>(R"EOF(
cluster_name: fare
endpoints:
- lb_endpoints:
- endpoint:
address:
socket_address:
address: 1.2.3.4
port_value: 80
policy:
overprovisioning_factor: 100
hidden_envoy_deprecated_disable_overprovisioning: true
)EOF");
EXPECT_THROW_WITH_REGEX(decodeTypedResource(cluster_load_assignment), ProtoValidationException,
"Illegal use of hidden_envoy_deprecated_ V2 field "
"'envoy.config.endpoint.v3.ClusterLoadAssignment.Policy.hidden_envoy_"
"deprecated_disable_overprovisioning'");
}

// Happy path.
TEST_F(OpaqueResourceDecoderImplTest, Success) {
envoy::config::endpoint::v3::ClusterLoadAssignment cluster_resource;
Expand Down