access_logger: correctly throw exception for grpc logger#17908
Merged
yanavlasov merged 10 commits intoenvoyproxy:mainfrom Sep 14, 2021
Merged
access_logger: correctly throw exception for grpc logger#17908yanavlasov merged 10 commits intoenvoyproxy:mainfrom
yanavlasov merged 10 commits intoenvoyproxy:mainfrom
Conversation
Signed-off-by: Takeshi Yoneda <takeshi@tetrate.io>
Signed-off-by: Takeshi Yoneda <takeshi@tetrate.io>
mathetake
commented
Aug 31, 2021
Contributor
|
/wait |
Signed-off-by: Takeshi Yoneda <takeshi@tetrate.io>
mathetake
force-pushed
the
access-logger-exception
branch
from
851204b to
1294f5e
Compare
Signed-off-by: Takeshi Yoneda <takeshi@tetrate.io>
yanavlasov
approved these changes
Sep 14, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Takeshi Yoneda takeshi@tetrate.io
Commit Message: access_logger: correctly throw exception for gRPC logger
Additional Description: As described in #15458, the current implementation of gRPC access loggers potentially throws exception in the worker threads due to usage of AsyncClientManager::factoryForGrpcService in the ThreadLocal::SlotPtr::set. This commit fixes this by checking the gRPC clusters' health in the main thread before going into the tls setters.
Risk Level: low
Testing: unittest
[Optional Fixes #Issue] istio/istio#34901 #15458