upstream: log event for outlier detection ejection and connection draining#17879
Merged
snowp merged 5 commits intoenvoyproxy:mainfrom Aug 27, 2021
Merged
upstream: log event for outlier detection ejection and connection draining#17879snowp merged 5 commits intoenvoyproxy:mainfrom
snowp merged 5 commits intoenvoyproxy:mainfrom
Conversation
Signed-off-by: Snow Pettersen <snowp@lyft.com>
snowp
changed the title
Signed-off-by: Snow Pettersen <snowp@lyft.com>
Signed-off-by: Snow Pettersen <snowp@lyft.com>
Signed-off-by: Snow Pettersen <snowp@lyft.com>
junr03
reviewed
Aug 26, 2021
Member
junr03
left a comment
junr03
left a comment
There was a problem hiding this comment.
thanks for adding. Just a comment about one of the lines.
| } | ||
|
|
||
| void ClusterManagerImpl::drainConnections(const std::string& cluster) { | ||
| ENVOY_LOG_EVENT(debug, "drain_connections_called", "drainConnections called for cluster {}", |
Member
There was a problem hiding this comment.
we use the overloaded function below that drains all clusters. Because of the threading they actually don't call each other. So the log event belongs below (or in both places if you want to leave this one here too).
Signed-off-by: Snow Pettersen <snowp@lyft.com>
junr03
approved these changes
Aug 26, 2021
buildbreaker
pushed a commit
to envoyproxy/envoy-mobile
that referenced
this pull request
Aug 28, 2021
Pulls in several instrumentation changes that make use of `ENVOY_LOG_EVENT`: - envoyproxy/envoy#17879 - envoyproxy/envoy#17833 - envoyproxy/envoy#17853 Signed-off-by: Jose Nino <jnino@lyft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Snow Pettersen snowp@lyft.com
Risk Level: Low, additional logging
Testing: n/a
Docs Changes: n/a
Release Notes: n/a
Platform Specific Features: n/a