Skip to content

h2: moving a comment #17846

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
phlax merged 1 commit into from
Aug 25, 2021
Merged

h2: moving a comment #17846

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions source/common/http/http2/codec_impl.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -326,10 +326,9 @@ class ConnectionImpl : public virtual Connection,
headers_or_trailers_(ResponseHeaderMapImpl::create()) {}

// Http::MultiplexedStreamImplBase
void setFlushTimeout(std::chrono::milliseconds /*timeout*/) override {
// Client streams do not need a flush timer because we currently assume that any failure
// to flush would be covered by a request/stream/etc. timeout.
}
// Client streams do not need a flush timer because we currently assume that any failure
// to flush would be covered by a request/stream/etc. timeout.
void setFlushTimeout(std::chrono::milliseconds /*timeout*/) override {}
// StreamImpl
void submitHeaders(const HeaderMap& headers, nghttp2_data_provider* provider) override;
// Do not use deferred reset on upstream connections.
Expand Down