kafka: record extractor for produce requests in mesh-filter#17839
Merged
mattklein123 merged 2 commits intoenvoyproxy:mainfrom Aug 26, 2021
Merged
kafka: record extractor for produce requests in mesh-filter#17839mattklein123 merged 2 commits intoenvoyproxy:mainfrom
mattklein123 merged 2 commits intoenvoyproxy:mainfrom
Conversation
Signed-off-by: Adam Kotwasinski <adam.kotwasinski@gmail.com>
Signed-off-by: Adam Kotwasinski <adam.kotwasinski@gmail.com>
mattklein123
approved these changes
Aug 26, 2021
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit Message: kafka: record extractor for produce requests in mesh-filter
Additional Description: to get to the Kafka messages (records) we need to do more processing of Kafka payloads (we need to read
record_setfield from protocol according to format. For now we are going to only support modern (what means Kafka 1.0 from 2017) format with magic = 2 (see line 4).Risk Level: Low
Testing: Unit tests
Docs Changes: N/A
Release Notes: N/A
Platform Specific Features: N/A