Skip to content

Revert "rocketmq: move to contrib (#17796)"#17831

Closed
phlax wants to merge 1 commit intoenvoyproxy:mainfrom
phlax:revert-17796
Closed

Revert "rocketmq: move to contrib (#17796)"#17831
phlax wants to merge 1 commit intoenvoyproxy:mainfrom
phlax:revert-17796

Conversation

@phlax
Copy link
Copy Markdown
Member

@phlax phlax commented Aug 24, 2021

This reverts commit 5b63ef4.

Signed-off-by: Ryan Northey ryan@synca.io

Commit Message: Revert "rocketmq: move to contrib (#17796)"
Additional Description:

Fix sync errors with go-control-plane in postsubmit

Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Deprecated:]
[Optional API Considerations:]

@repokitteh-read-only
Copy link
Copy Markdown

CC @envoyproxy/api-shepherds: Your approval is needed for changes made to api/envoy/.
envoyproxy/api-shepherds assignee is @markdroth
CC @envoyproxy/api-watchers: FYI only for changes made to api/envoy/.

🐱

Caused by: #17831 was opened by phlax.

see: more, trace.

@phlax
Copy link
Copy Markdown
Member Author

phlax commented Aug 24, 2021

cc @mattklein123 @alyssawilk

This reverts commit 5b63ef4.

Signed-off-by: Ryan Northey <ryan@synca.io>
@phlax
Copy link
Copy Markdown
Member Author

phlax commented Aug 24, 2021

pulling this, as it seems not to be immediately required

@phlax phlax closed this Aug 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants