Skip to content

build: Update RBE toolchan config#17716

Closed
yanavlasov wants to merge 10 commits intoenvoyproxy:mainfrom
yanavlasov:update-toolchains
Closed

build: Update RBE toolchan config#17716
yanavlasov wants to merge 10 commits intoenvoyproxy:mainfrom
yanavlasov:update-toolchains

Conversation

@yanavlasov
Copy link
Contributor

Additional Description:
Transition RBE toolchain config to the new one generated by the RBE config utility.
Risk Level: Low
Testing: RBE Builds
Docs Changes: N/A
Release Notes: N/A
Platform Specific Features: N/A

Signed-off-by: Yan Avlasov yavlasov@google.com

Signed-off-by: Yan Avlasov <yavlasov@google.com>
@repokitteh-read-only repokitteh-read-only bot added the deps Approval required for changes to Envoy's external dependencies label Aug 15, 2021
@repokitteh-read-only
Copy link

CC @envoyproxy/dependency-shepherds: Your approval is needed for changes made to (bazel/.*repos.*\.bzl)|(bazel/dependency_imports\.bzl)|(api/bazel/.*\.bzl)|(.*/requirements\.txt)|(.*\.patch).

🐱

Caused by: #17716 was opened by yanavlasov.

see: more, trace.

@yanavlasov
Copy link
Contributor Author

/retest

@repokitteh-read-only
Copy link

Retrying Azure Pipelines:
Retried failed jobs in: envoy-presubmit

🐱

Caused by: a #17716 (comment) was created by @yanavlasov.

see: more, trace.

Signed-off-by: Yan Avlasov <yavlasov@google.com>
Signed-off-by: Yan Avlasov <yavlasov@google.com>
@yanavlasov
Copy link
Contributor Author

/retest

@repokitteh-read-only
Copy link

Retrying Azure Pipelines:
Retried failed jobs in: envoy-presubmit

🐱

Caused by: a #17716 (comment) was created by @yanavlasov.

see: more, trace.

Signed-off-by: Yan Avlasov <yavlasov@google.com>
@yanavlasov
Copy link
Contributor Author

/retest

@repokitteh-read-only
Copy link

Retrying Azure Pipelines:
Retried failed jobs in: envoy-presubmit

🐱

Caused by: a #17716 (comment) was created by @yanavlasov.

see: more, trace.

Signed-off-by: Yan Avlasov <yavlasov@google.com>
@yanavlasov
Copy link
Contributor Author

Can we, do we have a 4.2 tag to capture, to see if that routes around the problem?

We do not at this point, I will have to rebuild the toolchain. Which I can. I'm however not even sure what difference this would make, since 3.7.2 and 4.1.0 directories for windows clang are identical.

lizan
lizan previously approved these changes Aug 23, 2021
@junr03
Copy link
Member

junr03 commented Aug 30, 2021

@yanavlasov do you want to merge this?

@wrowe
Copy link
Contributor

wrowe commented Aug 30, 2021

The present release today is 4.2.1. @yanavlasov could you bump this again?

@moderation
Copy link
Contributor

The present release today is 4.2.1. @yanavlasov could you bump this again?

Should https://github.com/envoyproxy/envoy/blob/main/.bazelversion#L1 be updated to 4.2.0 as per prior PR in this space https://github.com/envoyproxy/envoy/pull/16644/files?

Similarly https://github.com/envoyproxy/envoy/pull/16644/files should be bumped to 4.2.0

@zuercher
Copy link
Member

zuercher commented Sep 8, 2021

/wait

@yanavlasov
Copy link
Contributor Author

Closing for now. The platform targets are incorrectly set to use toolchains for bazel 3.7.1 only. I'm fixing this right now on build-tools. Will reopen once it is fixed.

Also bazel version on main is 4.1.0 not 4.2.0. bazel version will be bumped separately, I want to make sure the existing config is fully functional first.

@yanavlasov yanavlasov closed this Sep 8, 2021
@yanavlasov yanavlasov reopened this Sep 14, 2021
Signed-off-by: Yan Avlasov <yavlasov@google.com>
Signed-off-by: Yan Avlasov <yavlasov@google.com>
Copy link
Contributor

@wrowe wrowe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You omitted the updates of the other references to toolchain image 55d9e4719d2bd0accce8f829b44dab70cd42112a

Please correct. (I'm checking this out locally.)

@wrowe
Copy link
Contributor

wrowe commented Sep 15, 2021

Also bazel version on main is 4.1.0

Actually, the envoy build containers in use in CI are 3.7.2 only, from 55d9e4 on May 6th. New toolchains with bazel 4.1 were generated with commit 78588b on May 25th, but these build containers never went live.

Signed-off-by: Yan Avlasov <yavlasov@google.com>
Signed-off-by: Yan Avlasov <yavlasov@google.com>
@alyssawilk
Copy link
Contributor

/wait on CI

@lizan
Copy link
Member

lizan commented Sep 21, 2021

@yanavlasov need to update image references in bunch of places otherwise ci script fails to detect clang locations.

@yanavlasov
Copy link
Contributor Author

Obsoleted by PR #18220

@yanavlasov yanavlasov closed this Sep 28, 2021
@yanavlasov yanavlasov deleted the update-toolchains branch September 28, 2021 19:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

deps Approval required for changes to Envoy's external dependencies waiting

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants