hot_restart.rst: update outdated detailed information#17653
hot_restart.rst: update outdated detailed information#17653ggreenway merged 5 commits intoenvoyproxy:mainfrom
Conversation
Signed-off-by: qinggniq <livewithblank@gmail.com>
| consistent across both processes as restart is taking place. | ||
| * The two active processes communicate with each other over unix domain sockets using a basic RPC | ||
| protocol. | ||
| protocol. Statistics will be transported from the old process to the new process over the unix domain. |
There was a problem hiding this comment.
We do not transport all stats - It would be good to qualify
There was a problem hiding this comment.
Do you mean counters and gauges?
There was a problem hiding this comment.
yes. For example, all gauges are not transported
There was a problem hiding this comment.
AFAIK, during hot restart, all counters and gauges will be transported to the new process, but after the new process sending the terminate request, the new process will clean up the contributions of most gauges transported from the old process except hot_restart_generation stat. Am I misunderstand?
There was a problem hiding this comment.
Some gauges are transported and some are not. Each gauge is marked as never import, import, etc.
Signed-off-by: qinggniq <livewithblank@gmail.com>
Signed-off-by: qinggniq <livewithblank@gmail.com>
Signed-off-by: qinggniq <livewithblank@gmail.com>
ggreenway
left a comment
ggreenway
left a comment
There was a problem hiding this comment.
Thanks for this correction!
/wait
| consistent across both processes as restart is taking place. | ||
| * The two active processes communicate with each other over unix domain sockets using a basic RPC | ||
| protocol. | ||
| protocol. All counters are from the old process to the new process over the unix domain, while part |
There was a problem hiding this comment.
"All counters are sent from the"
There was a problem hiding this comment.
s/"while part of gauges are transported"/"and gauges are transported except those marked with NeverImport"/
| * The two active processes communicate with each other over unix domain sockets using a basic RPC | ||
| protocol. | ||
| protocol. All counters are from the old process to the new process over the unix domain, while part | ||
| of gauges are transported. After hot restart finished, the gauges transported from the old process |
There was a problem hiding this comment.
"After hot restart is finished"
Signed-off-by: qinggniq <livewithblank@gmail.com>
…roxy#17653) Signed-off-by: qinggniq <livewithblank@gmail.com>
4 participants
Signed-off-by: qinggniq livewithblank@gmail.com
After #5910, stats are transported over unix domain rather than shared memory.
Commit Message: hot_restart.rst: update outdated detailed information
Additional Description:
Risk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Deprecated:]
[Optional API Considerations:]