hcm/listener_manager: remove deprecated v2 config handling.#17586
Merged
htuch merged 2 commits intoenvoyproxy:mainfrom Aug 5, 2021
Merged
hcm/listener_manager: remove deprecated v2 config handling.#17586htuch merged 2 commits intoenvoyproxy:mainfrom
htuch merged 2 commits intoenvoyproxy:mainfrom
Conversation
Risk level: Low Testing: Removed deprecated tests. Signed-off-by: Harvey Tuch <htuch@google.com>
alyssawilk
approved these changes
Aug 5, 2021
| NOT_REACHED_GCOVR_EXCL_LINE; | ||
| } | ||
| // Continuing legacy behavior; if unspecified, we treat this as ingress. | ||
| tracing_operation_name = Tracing::OperationName::Ingress; |
Contributor
There was a problem hiding this comment.
Arguably we could throw on unspecified? Before we'd require now deprecated config or crash.
Member
Author
There was a problem hiding this comment.
I think before this was an enum, so it would have defaulted to ingress (default enum value).
baojr
added a commit
to baojr/envoy
that referenced
this pull request
Aug 5, 2021
…bridge-stream * upstream/main: stream info: add upstream connection id (envoyproxy#17512) runtime: removing require_ocsp_response_for_must_staple_certs (envoyproxy#17541) tooling: Fixes/cleanups/tests for `rst_checks.py` (envoyproxy#17589) Add a new HappyEyeballsConnectionImpl class (envoyproxy#17371) hcm/listener_manager: remove deprecated v2 config handling. (envoyproxy#17586) tools: simplify bazel deps query (envoyproxy#17599) tooling: Move tempdir/cleanup to base runner class (envoyproxy#17590) tools: fix missing format strings (envoyproxy#17600) tooling: Add `@envoy` prefix in `envoy_py_` macros (envoyproxy#17588) stream info: add attempt count for HTTP requests and TCP proxy (envoyproxy#17583) Signed-off-by: Garrett Bourg <bourg@squareup.com>
leyao-daily
pushed a commit
to leyao-daily/envoy
that referenced
this pull request
Sep 30, 2021
…xy#17586) Risk level: Low Testing: Removed deprecated tests. Signed-off-by: Harvey Tuch <htuch@google.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Risk level: Low
Testing: Removed deprecated tests.
Signed-off-by: Harvey Tuch htuch@google.com