Skip to content

conn pool: default enable runtime feature conn_pool_delete_when_idle #17577

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ggreenway merged 1 commit into from
Aug 4, 2021
Merged

conn pool: default enable runtime feature conn_pool_delete_when_idle #17577

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions source/common/runtime/runtime_features.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,7 @@ constexpr const char* runtime_features[] = {
"envoy.reloadable_features.add_and_validate_scheme_header",
"envoy.reloadable_features.allow_response_for_timeout",
"envoy.reloadable_features.check_unsupported_typed_per_filter_config",
"envoy.reloadable_features.conn_pool_delete_when_idle",
"envoy.reloadable_features.correct_scheme_and_xfp",
"envoy.reloadable_features.disable_tls_inspector_injection",
"envoy.reloadable_features.dont_add_content_length_for_bodiless_requests",
Expand Down Expand Up @@ -110,9 +111,6 @@ constexpr const char* runtime_features[] = {
constexpr const char* disabled_runtime_features[] = {
// v2 is fatal-by-default.
"envoy.test_only.broken_in_production.enable_deprecated_v2_api",
// Defaulting to off due to high risk.
// TODO(ggreenway): Move this to default-on during 1.20 release cycle.
"envoy.reloadable_features.conn_pool_delete_when_idle",
// TODO(asraa) flip to true in a separate PR to enable the new JSON by default.
"envoy.reloadable_features.remove_legacy_json",
// Sentinel and test flag.
Expand Down