Skip to content

test: improving tracer coverage #17493

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
alyssawilk merged 1 commit into from
Jul 27, 2021
Merged

test: improving tracer coverage #17493

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions source/extensions/tracers/opencensus/opencensus_tracer_impl.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,6 @@ startSpanHelper(const std::string& name, bool traced, const Tracing::TraceContex
}
break;
}

case OpenCensusConfig::GRPC_TRACE_BIN: {
const auto entry = trace_context.getTraceContext(Constants::get().GRPC_TRACE_BIN);
if (entry.has_value()) {
Expand All @@ -114,7 +113,6 @@ startSpanHelper(const std::string& name, bool traced, const Tracing::TraceContex
}
break;
}

case OpenCensusConfig::CLOUD_TRACE_CONTEXT: {
const auto entry = trace_context.getTraceContext(Constants::get().X_CLOUD_TRACE_CONTEXT);
if (entry.has_value()) {
Expand Down Expand Up @@ -212,20 +210,17 @@ void Span::injectContext(Tracing::TraceContext& trace_context) {
trace_context.setTraceContextReferenceKey(
Constants::get().TRACEPARENT, ::opencensus::trace::propagation::ToTraceParentHeader(ctx));
break;

case OpenCensusConfig::GRPC_TRACE_BIN: {
std::string val = ::opencensus::trace::propagation::ToGrpcTraceBinHeader(ctx);
val = Base64::encode(val.data(), val.size(), /*add_padding=*/false);
trace_context.setTraceContextReferenceKey(Constants::get().GRPC_TRACE_BIN, val);
break;
}

case OpenCensusConfig::CLOUD_TRACE_CONTEXT:
trace_context.setTraceContextReferenceKey(
Constants::get().X_CLOUD_TRACE_CONTEXT,
::opencensus::trace::propagation::ToCloudTraceContextHeader(ctx));
break;

case OpenCensusConfig::B3:
trace_context.setTraceContextReferenceKey(
Constants::get().X_B3_TRACEID, ::opencensus::trace::propagation::ToB3TraceIdHeader(ctx));
Expand Down
10 changes: 0 additions & 10 deletions source/extensions/tracers/zipkin/zipkin_core_types.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -251,11 +251,6 @@ class BinaryAnnotation : public ZipkinBase {
*/
AnnotationType annotationType() const { return annotation_type_; }

/**
* Sets the binary's annotation type.
*/
void setAnnotationType(AnnotationType annotation_type) { annotation_type_ = annotation_type; }

/**
* @return the annotation's endpoint attribute.
*/
Expand All @@ -266,11 +261,6 @@ class BinaryAnnotation : public ZipkinBase {
*/
void setEndpoint(const Endpoint& endpoint) { endpoint_ = endpoint; }

/**
* Sets the annotation's endpoint attribute (move semantics).
*/
void setEndpoint(const Endpoint&& endpoint) { endpoint_ = endpoint; }

/**
* @return true if the endpoint attribute is set, or false otherwise.
*/
Expand Down
1 change: 1 addition & 0 deletions test/extensions/tracers/xray/tracer_test.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -276,6 +276,7 @@ TEST_F(XRayTracerTest, SerializeSpanTestWithStatusCodeNotANumber) {
span->setTag(Tracing::Tags::get().UserAgent, expected_->user_agent);
span->setTag(Tracing::Tags::get().HttpStatusCode, expected_status_code);
span->setTag(Tracing::Tags::get().ResponseSize, expected_content_length);
span->setTag("", "");
span->finishSpan();
}

Expand Down
1 change: 0 additions & 1 deletion test/per_file_coverage.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,6 @@ declare -a KNOWN_LOW_COVERAGE=(
"source/extensions/stat_sinks/common/statsd:96.5"
"source/extensions/stat_sinks/graphite_statsd:85.7"
"source/extensions/stat_sinks/statsd:85.2"
"source/extensions/tracers:96.5"
"source/extensions/tracers/opencensus:92.5"
"source/extensions/tracers/xray:94.0"
"source/extensions/transport_sockets:95.7"
Expand Down