Skip to content

docs: Fix the confusing word in http3 upsteam documents#17481

Merged
phlax merged 2 commits intoenvoyproxy:mainfrom
leyao-daily:typo
Jul 26, 2021
Merged

docs: Fix the confusing word in http3 upsteam documents#17481
phlax merged 2 commits intoenvoyproxy:mainfrom
leyao-daily:typo

Conversation

@leyao-daily
Copy link
Copy Markdown
Member

Signed-off-by: Le Yao le.yao@intel.com

Commit Message: Fix the confusing word in http3 upsteam section
Additional Description: The Altnernate confused the readers, I think it may be Alternate.
Risk Level: Low
Testing: N/A
Docs Changes: Yes
Release Notes: N/A
Platform Specific Features: N/A

Signed-off-by: Le Yao <le.yao@intel.com>
@leyao-daily
Copy link
Copy Markdown
Member Author

And what in my consideration is that what alt-svc here means? "HTTP Alternate Service" or "HTTP Alternative Service"?

phlax
phlax previously approved these changes Jul 26, 2021
Copy link
Copy Markdown
Member

@phlax phlax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks @leyao-daily

@phlax
Copy link
Copy Markdown
Member

phlax commented Jul 26, 2021

"HTTP Alternate Service" or "HTTP Alternative Service"?

not sure, they are fairly semantically equivalent

seems like in this case "Alternative" is used in official docs etc, eg

https://httpwg.org/specs/rfc7838.html#alt-svc

@leyao-daily do you want to change it to alternative ?

@phlax phlax self-assigned this Jul 26, 2021
Signed-off-by: Le Yao <le.yao@intel.com>
@leyao-daily
Copy link
Copy Markdown
Member Author

"HTTP Alternate Service" or "HTTP Alternative Service"?

not sure, they are fairly semantically equivalent

seems like in this case "Alternative" is used in official docs etc, eg

https://httpwg.org/specs/rfc7838.html#alt-svc

@leyao-daily do you want to change it to alternative ?

I think alternative is more common in official docs. So should I change it to alternative. :)

@phlax
Copy link
Copy Markdown
Member

phlax commented Jul 26, 2021

So should I change it to alternative. :)

i think yes

@leyao-daily
Copy link
Copy Markdown
Member Author

So should I change it to alternative. :)

i think yes

Fixed.

Copy link
Copy Markdown
Member

@phlax phlax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks @leyao-daily

@phlax phlax merged commit 507f5e6 into envoyproxy:main Jul 26, 2021
@leyao-daily leyao-daily deleted the typo branch July 28, 2021 05:17
leyao-daily pushed a commit to leyao-daily/envoy that referenced this pull request Sep 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants