Conversation
repokitteh-read-only
bot
added
the
deps
phlax
force-pushed
the
tooling-cleanups-utils
branch
4 times, most recently
from
5c51988 to
dbc2f8b
Compare
|
coverage is here https://storage.googleapis.com/envoy-pr/17477/tooling/index.html |
phlax
force-pushed
the
tooling-cleanups-utils
branch
2 times, most recently
from
45422ee to
5c15509
Compare
phlax
force-pushed
the
tooling-cleanups-utils
branch
4 times, most recently
from
e5b695f to
01483be
Compare
Signed-off-by: Ryan Northey <ryan@synca.io>
phlax
force-pushed
the
tooling-cleanups-utils
branch
from
01483be to
3811de1
Compare
|
@htuch i pushed again not realizing you had reviewed - could you take another look - thanks! (apologies for force-pushing after review) |
|
fyi, the change was removing some extraneous code that i had added in the wrong place initially |
|
|
||
| def from_yaml(path: str) -> Union[dict, list, str, int]: | ||
| """Returns the loaded python object from a yaml file given by `path`""" | ||
| with open(path) as f: |
There was a problem hiding this comment.
Not that it matters a lot, but maybe we could move in the future to simpler pathlib read_text() here and write_text() below.
There was a problem hiding this comment.
yep, agreed
theres some things i dont like about pathlib (like the duplication with os) but tbh i find myself thinking "hmm, i could do with some kind of object-oriented path representaiton" which is in fact exactly what pathlib is
if its ok - ill go through and do some pathlib cleanups en masse at some point
Signed-off-by: Ryan Northey <ryan@synca.io>
2 participants
Signed-off-by: Ryan Northey ryan@synca.io
Commit Message: tooling: Cleanups and utils
Additional Description:
some minor cleanups and yaml utils
this also makes yaml a dependency of
base.utilswhich will hopefully help to cut dep sprawlRisk Level:
Testing:
Docs Changes:
Release Notes:
Platform Specific Features:
[Optional Runtime guard:]
[Optional Fixes #Issue]
[Optional Deprecated:]
[Optional API Considerations:]