Remove unused powershell call from Windows docker file#17472
Merged
wrowe merged 1 commit intoenvoyproxy:mainfrom Jul 26, 2021
Merged
Remove unused powershell call from Windows docker file#17472wrowe merged 1 commit intoenvoyproxy:mainfrom
wrowe merged 1 commit intoenvoyproxy:mainfrom
Conversation
Signed-off-by: Sotiris Nanopoulos <sonanopo@microsoft.com>
Member
Author
|
cc @envoyproxy/windows-dev |
sunjayBhatia
approved these changes
Jul 26, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ever since #15461 we no longer have a reference to
/tmp/inenvoyproxy_io_proxy.yamlso we do not need this powershell call.Removing this call is important because it allows to build the Envoy Windows Container on
Nanoserverwhich is required for #16759Risk Level: Low
Testing: Manually build the container
Docs Changes: N/A
Release Notes: N/A (Null-Op)
Platform Specific Features: Windows only
Signed-off-by: Sotiris Nanopoulos sonanopo@microsoft.com